Use native DB.Ping() instead of self-written implementation

[arvenil]

I know it's trivial :P But I'm curious why not use native DB.Ping() instead of in-house implementation? It should also avoid generating unnecessary SELECT 1 statements.

[SuperQ]

Totally reasonable to me, the SELECT 1 pattern came from some app implementations with bad SQL drivers. This is better.

[SuperQ]

LGTM

[SuperQ]

One note, we need to update the go mysql driver vendoring, as the Ping() function is not implemented in the current version. I will send out a general vendoring update PR.

[SuperQ]

It looks like this was only implemented recently0 and is not in an official release of the driver just yet. I think I want to hold off on this and wait till the upstream driver declares it in a stable release.

[arvenil]

Interesting. Just to clarify.

https://golang.org/pkg/database/sql/#DB.Ping is there since like forever™️
I just read DB.Ping is making a new connection to DB (which often is enough) but with implementation of Pinger interface it will now also send ping packet to db (definitely better and more close to SELECT 1 query test).

👍

[SuperQ]

Looks like this needs a rebase.

[SuperQ]

FYI, I'm not ignoring this, but there is still no upstream release of the driver that contains the new db.Ping() version.

[SuperQ]

We've merged 1.4.0, please rebase. 😄

[arvenil]

Done.