Skip to content

Allow excludedatabases when using file_per_database #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

Allow excludedatabases when using file_per_database #1480

merged 1 commit into from
Aug 11, 2022

Conversation

HT43-bqxFqB
Copy link
Contributor

Fixes #449 #461

@HT43-bqxFqB HT43-bqxFqB requested a review from a team as a code owner July 12, 2022 15:00
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

This module is declared in 140 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

HT43-bqxFqB
HT43-bqxFqB commented Jul 12, 2022
View reviewed changes
manifests/backup/mysqldump.pp Outdated
@@ -33,6 +33,7 @@
$compression_command = 'bzcat -zc',
$compression_extension = '.bz2',
$backupmethod_package = undef,
Array[Strings] $excludedatabases = [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can indent the other parameters as well.

Copy link
Contributor

@LukasAud LukasAud Aug 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could indent the other parameters, that would be great. Once that is done, I will be happy to merge this PR 👍

@HT43-bqxFqB
Copy link
Contributor Author

Is anyone able to review this PR?

HT43-bqxFqB added a commit to ibmix-berlin/puppetlabs-mysql that referenced this pull request Aug 2, 2022
@HT43-bqxFqB
Test simpler regex and make template code simpler puppetlabs#1480
af65712
@HT43-bqxFqB
Copy link
Contributor Author

Commits are now squashed ✔️

@LukasAud LukasAud merged commit 0feb683 into puppetlabs:main Aug 11, 2022
@LukasAud
Copy link
Contributor

Hey @HT43-bqxFqB, I'm happy to merge this one. Do not worry about the indentation, we'll make a quick fix as soon as we release it.

Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to exclude certain databases
5 participants
@HT43-bqxFqB @CLAassistant @LukasAud @GSPatton @ia-content