Added prototype excludedatabases option to mysql::server::backup #461
Conversation
|
This will need spec/acceptance tests. https://travis-ci.org/puppetlabs/puppetlabs-mysql/jobs/19483070#L402 Bonus, if it actually extends those tests to test this new functionality. |
| @@ -40,7 +40,7 @@ cleanup | |||
| <% end -%> | |||
| <% if @backupdatabases.empty? -%> | |||
| <% if @file_per_database -%> | |||
| mysql -s -r -N -e 'SHOW DATABASES' | while read dbname | |||
| mysql -s -r -N -e 'SHOW DATABASES'<% if [email protected]? %> | grep -v '^\(<%= @excludedatabases.join('\|') %>\)$'<% end %> | while read dbname | |||
There was a problem hiding this comment.
When you use '', there's no need to escape |, but I think you will have to add a -E option to grep (one way or another, just to be sure ;)
|
I'm sorry for neglecting this patch for so long :( I've been really busy with $dayjob. Can you please add spec/classes/mysql_server_backup_spec.rb and spec/acceptance/mysql_bacckup_spec.rb Once you're think you're done please rebase and squash it down to one or two commits. |
|
I have no idea how to add the specs for it at the moment. Sure I can figure it out, but have been busy a bit so may take a while. |
|
I'd start with rebasing so you have the latest updates to Gemfile, (and installing the latest vagrant and virtualbox), then % bundle installTo run tests % bundle exec rspec spec/acceptance |
|
Hey @robrwo! |
|
Hi @igalic Sorry, I've been very busy with my day job and have had no time to work on the tests. |
|
@robrwo thanks for the contribution, but unfortunately at this time this PR is not mergeable without a rebase and the addition of tests. I'm going to close this PR for now, but if someone wants to handle the testing and rebasing we'd be happy to review a new PR. |
|
@mhaskel I'm working for a different company that doesn't use MySQL, so am unable to continue working on this patch now. |
As per #449