Fix: database_user type being declared twice with mysql::db #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes database_user type being declared twice when adding the same user to different databases with mysql::db, by adding a :user parameter instead of using :name in the type and provider definitions.
|
@alexmingoia Take a look at #154. What do you think about my proposal? |
|
Your patch is much better. I had to look up what ensure_resource() was and it seems messy that puppet has a stdlib for such basic things that should be part of Puppet's declarative language. I'll definitely familiarize myself with that module. After all, I came up with my approach by reading the puppetlabs docs (which encourage unique names to avoid duplicate declaration problems). |
|
I'm going to close this one for now as it looks like #154 continued this work. |
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
(maint) Add enable and disable actions for *nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes database_user type being declared twice when adding the same user to
different databases with mysql::db, by adding a :user parameter instead of using
:name in the type and provider definitions.