Fix issue with redeclaration of database_user via mysql::db #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this patch is more interesting then #151 because this one doesn't break a lot of tests. |
kbarber
added a commit
that referenced
this pull request
Feb 18, 2013
Fix issue with redeclaration of database_user via mysql::db
|
this breaks compatibility with older versions of Puppet (I have travis jobs where this is failing on 2.6.9 [1]). What version are we targeting as supported? I was previously targeting 2.6.9 b/c of epel (which I can update to 2.6.17 now). I also noticed that the travis builds for this module are also failing b/c of 2.6 issues (which may be related to this pull request) [1] https://travis-ci.org/puppetlabs/puppetlabs-openstack/jobs/5176994 |
|
2.6.17 was a no go, the issue is that anonymous hashes were not fully supported in 2.6.x. I will see if I can craft a PR that makes this backwards compatible. |
pmcmaw
added a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
pdksync - (IAC-973) - Update travis/appveyor to run on new default branch `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix failed tests