Skip to content

Drop legacy facts #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Drop legacy facts #1535

wants to merge 7 commits into from

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Feb 15, 2023

Puppet 8 will default to not send legacy facts. Update the module so that it uses the facts that superseded these legacy facts.

@smortex smortex requested a review from a team as a code owner February 15, 2023 19:09
@puppet-community-rangefinder
Copy link

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::bindings is a class

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server::account_security is a class

Breaking changes to this file WILL impact these 5 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

mysql::server::root_password is a class

that may have no external impact to Forge modules.

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex
Copy link
Contributor Author

smortex commented Feb 15, 2023

RedHat 7 failure seems to be a transient one. Also the mend failure is caused by a lack of license key, so unrelated to this change.

This is ready for review!

@smortex
Copy link
Contributor Author

smortex commented Feb 22, 2023

Close in favor of #1532

@smortex smortex closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants