Skip to content

Variables are incorrectly set in the default section of the case in params.pp #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justintime
Copy link

99% of installations won't ever hit the default.

Moving the variables to just after the case statement will set
them, removing the default part of the case will cause this class
to fail on unsupported distros.

ever hit the default.

Moving the variables to just after the case statement will set
them, removing the default part of the case will cause this class
to fail on unsupported distros.
@ccaum
Copy link
Contributor

ccaum commented Jan 11, 2012

My use_mysql_gem_for_provider branch should resolve this. We'll need the $ruby_package_name and $ruby_package_provider variables for all distros. Once that branch gets merged, is this still necessary?

@justintime
Copy link
Author

Bah, I'm sorry. I pointed this pull request at a commit instead of a branch. Here's the one we should be looking at: #35

You could merge that branch either into this branch or your mysql_gem branch, but it will need done at some point.

@justintime justintime closed this Jan 11, 2012
pmcmaw pushed a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants