Rhel centos support #35
Conversation
ever hit the default. Moving the variables to just after the case statement will set them, removing the default part of the case will cause this class to fail on unsupported distros.
a $config_file variable to allow per-distro config file destinations.
|
@ghoneycutt - good idea, committed and pushed 92290b3. |
| } | ||
| } | ||
| $python_package_name = 'python-mysqldb' | ||
| $ruby_package_name = 'ruby-mysql' |
There was a problem hiding this comment.
This doesn't make sense to me. The package name is different for ubuntu and centos
There was a problem hiding this comment.
Yep, they sure are :)
I don't use the python libs on CentOS, so that's why I didn't catch that. Since I'm on CentOS, and that's what the variable was set to, I didn't see that.
Commit c21c393 should fix this.
|
+1. Thanks for working on this! |
|
Bug filed at: http://projects.puppetlabs.com/issues/11916 |
|
@justintime Do you have any experience with rspec-puppet? The only thing left I'd love to see here is a spec test to ensure the my.cnf file has the proper title depending on the OS. This will protect against regressions. Take a look at the spec tests provided in my use_gem_for_provider branch. I only have a few tests so far, but I'm trying to always add tests for manifest changes. |
|
@ccaum I've heard of it, but not used it. I'm very good with Perl, but On Thu, Jan 12, 2012 at 11:14 PM, Carl Caum <
|
|
@justintime No worries. If you're willing to work on it then cool. If not, I don't mind doing it. It'll just take me a few weeks before I can touch it. A lot on my schedule at the moment. Feel free to browse around the tests inside the /spec/classes directory in my branch. It's pretty clear how to write tests for manifests. |
|
@justintime Hi, I actually merged a pull request from Nan that I believe contains all of the commits mentioned here. I am closing this pull request with the assumption that everything in it has already been resolved. If you could verify that, I would be appreciative. |
|
Hi Dan -- unfortunately I can't really test because my fork has diverged Justin On Thu, Mar 15, 2012 at 11:51 AM, Dan Bode <
|
(MODULES-6881) - Removing duplicaton in .sync.yml
There's a few issues with running this module on RHEL/CentOS, this branch attempts to fix them.
The biggest problem is the location of the mysql socket location, but another is that RHEL/CentOS uses /etc/my.cnf instead of /etc/mysql/my.cnf.