changes required to enable replication #762
Conversation
| $master_slave = $mysql::server::master_slave | ||
| $server_id = $mysql::server::rep_server_id | ||
|
|
||
| if $mysql::server::replication_enable { |
There was a problem hiding this comment.
Please make the inclusion of the replication class optional in the mysql::server, instead of protecting the contents. This makes it easier to compose manually, in those ugly edge cases.
|
Hi @markasammut , Thanks for your contribution! I've added a few comments to the code. Generally this would be a good change. Please make sure that the additional functionality is also documented in the README and that there are at least basic tests in place. Also, for final inclusion, please squash all you commits into one, so that the git history remains readable: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits If you have experience with replication, it'd be great if you could have a look at #765 and chime in there. Regards, David |
|
Hi @markasammut, I'm going to close this PR as stale, can you reopen when you are available to address the issues pointed out by @DavidS above? Thanks! |
No description provided.