Ticket Forge Modules / MODULES-2675 - Unique server_id #765
Conversation
…be used in calculating the unique id.
|
Hi @jmk61 , thanks for your contribution! Would you be son nice and squash this into a single commit, so as to keep the history clean? See Squashing: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits |
|
A more difficult question: how is this fact used, and how will changing it's output impact the users of this? |
|
The fact is used to determine a unique server ID within the my.cnf which allows master-slave setups. By modifying the fact it will change the users server_id within their conf. It shouldn't have a direct effect on existing setups as I'm unware of a way to directly utilize this information within a setup other then distinguishing each mysql server in your setup. Please let me know your thoughts, questions and concerns. Thanks Joseph Karns ----- Reply message ----- A more difficult question: how is this fact used, and how will changing it's output impact the users of this? Reply to this email directly or view it on GitHub: The fact is used to determine a unique server ID within the my.cnf which allows master-slave setups. By modifying the fact it will change the users server_id within their conf. It shouldn't have a direct effect on existing setups as I'm unware of a way to directly utilize this information within a setup other then distinguishing each mysql server in your setup. Please let me know your thoughts, questions and concerns. Thanks Joseph Karns ----- Reply message ----- |
…ate the unique id. Also set the correct value of the unique id based off the macaddress in the spec test.
…k61/puppetlabs-mysql into ticket/MODULES-2675_server_id * 'ticket/MODULES-2675_server_id' of https://github.com/jmk61/puppetlabs-mysql: Fixed server_id Spec Test with correct value Setting Total to 6. This allows all six splits of the mac address to be used in calculating the unique id.
|
David: Not sure if I did the squash correct. If not request the pull request and I'll resubmit. Thanks |
|
Yeah, this branch doesn't look like it should. Also, I'm still not 100% clear what happens to an existing replication setup, when all the |
|
Closing in preference to #767 |
Ticket Forge Modules / MODULES-2675
Fixed Unique server_id facter fact. Allowing a unique id to be generated by reading in all 6 splits of the mac address, where as it was only reading in 4 of the 6 splits.