(MODULES-2767) allow to check if table exists before grant #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| else | ||
| raise(Puppet::ParseError, 'mysql_table_exists() accept 1 argument - table string like \'database_name.table_name\'') | ||
| end |
There was a problem hiding this comment.
we should revert this whole thing for early returns:
return raise(Puppet::ParseError, "mysql_table_exists() accept 1 argument - table string like 'database_name.table_name'") unless match = args[0].match(/(.*)\.(.*)/)
db_name, table_name = match.captures
return true if (db_name.eql?('*') or table_name.eql?('*')) # this is actually not true
query = "SELECT TABLE_NAME FROM information_schema, tables WHERE TABLE_NAME etc.."
%x{mysql etc..}
|
@igalic thank you for pointing this out! Fixed |
igalic
added a commit
that referenced
this pull request
Nov 9, 2015
(MODULES-2767) allow to check if table exists before grant
|
thank you @pondohva! |
|
thank you, @igalic . Now we have problem with rspec test - https://travis-ci.org/puppetlabs/puppetlabs-mysql/builds/90054252 (it's my fault, sorry), and I've forgotten check for args.size in function body. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.