Remove mysql_table_exists() function #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors unrelated; #816 fixes them. |
This function is intended to check for the existence of a table before declaring some resource, but this is neither portable (because functions orun on the master, not the agent) nor one-run idempotent (because the function would run before mysql is even installed, and would take two runs to do anything). The correct way of doing this would be to update the providers and dependency ordering to handle the conditional states. Luckily this was never released so it is backwards compatible.
|
reviews |
|
Can you please let me know what if wrong with that fix? Please help me to understand what is wrong and I can address the problem properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is intended to check for the existence of a table before
declaring some resource, but this is neither portable (because functions
run on the master, not the agent) nor one-run idempotent (because the
function would run before mysql is even installed, and would take two
runs to do anything).
The correct way of doing this would be to update the providers and
dependency ordering to handle the conditional states.
Luckily this was never released so it is backwards compatible.