14870 Allow custom my cnf

[walterheck]

https://projects.puppetlabs.com/issues/14870

[glarizza]

Hi Walter :)
That's quite a few commits for 4 insertions and 3 deletions. It would be ideal to squash those down to a single commit before submitting a pull request - it makes it easier to follow (as it stands, you've committed and then removed a template that's irrelevant to this pull request, but they're two separate commits. We really don't need to see those commits for this pull request).

Also, is there any reason you chose to default the $mysql::config::my_cnf_template to a value in this class instead of a value in the params class like the other parameters?

[walterheck]

On Fri, Jun 8, 2012 at 1:27 AM, Gary Larizza
[email protected]
wrote:

That's quite a few commits for 4 insertions and 3 deletions.  It would be ideal to squash those down to a single commit before submitting a pull request - it makes it easier to follow (as it stands, you've committed and then removed a template that's irrelevant to this pull request, but they're two separate commits.  We really don't need to see those commits for this pull request).

Yeah, Im not sure why github wanted to send you guys all those
commits. I branched and made 2 commits in that branch, and that was
what I wanted to propose to merge to you guys, but apparently it took
everything from when I forked months back. Any idea how I fix this
properly? How do i "squash this down to a single commit"?

Also, is there any reason you chose to default the $mysql::config::my_cnf_template to a value in this class instead of a value in the params class like the other parameters?

The reason being that it was a constant, and it didn't look like it
made a whole lot of sense to put it in the params class. Now, at a
second look (after a good night sleep ;) ) that actually would make
sense. If you tell me how to squash all of this into a single commit,
I'll add the params stuff as well.

Walter Heck

Check out my startup: Puppet training and consulting @ http://www.olindata.com
Follow @olindata on Twitter and/or 'Like' our Facebook page at
http://www.facebook.com/olindata

[smerrill]

How about #99 ?

[branan]

This is getting stale, plus:

It's something of an antipattern to allow the user to override config templates - it usually means the existing module classes need to be fixed.

#98 adds a whole host of additional parameters to the existing MySQL config template, and we're going to try to get that merged soon. Once that's in you're welcome to submit pull requests for any other parameter(s) or options needed.