Skip to content

Add parameterization changes from wikipedia. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bodepd
Copy link
Contributor

@bodepd bodepd commented Aug 16, 2012

No description provided.

emonty and others added 2 commits August 15, 2012 18:13
This commit resolves a few small errors that were introduced
in Monty's parameter adding patch.

All of these resolved errors were preventing the catalog from
being applied correctly.

- removes second reference to $tmp_table_size
- removes reference in template to undefined variables tmpdir and gid
@hunner
Copy link
Contributor

hunner commented Oct 4, 2012

Even with #93, I think this pull request is still viable. It makes many of the defaults tweakable, and is a much cleaner original template.

This needs rebasing, and I would like tests for the added parameters, though I don't know if that should be a merge blocker. (We don't have a policy on that.)

@ryanycoleman
Copy link

@bodepd Are we going down this path or dropping the pull request?

@hunner
Copy link
Contributor

hunner commented Oct 15, 2012

I would defer this to @bodepd. But would endorse it for the previously stated reasons.

@bodepd
Copy link
Contributor Author

bodepd commented Oct 15, 2012

I would prefer to drop it in favor of writing native types to manage the ini config file.

https://github.com/bodepd/puppetlabs-glance/blob/folsom/lib/puppet/provider/glance_api_config/ini_setting.rb

This way users can add whatever customization they want from top scope. and the config class can just contain reasonable defaults.

@hunner
Copy link
Contributor

hunner commented Oct 15, 2012

@bodepd You'll probably want to expand on that. Do you think you could write a short blurb about how to use the ini_setting type?

@ryanycoleman
Copy link

@bodepd, do you think we ought to still provide the class interfaces and just back them with ini_setting declarations instead of templates?

@hunner hunner closed this Jan 4, 2013
pmcmaw added a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
(FM-8159) Add Windows Server 2019 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants