Fix transitive dependencies errors in spago 0.20.0 #71
Conversation
|
Having trouble reproducing the CI failure locally. This command works fine for me: |
|
We can remove the unused function — that’s a 0.14.1 warning. I’m not sure why you aren’t seeing it locally. |
| {- | ||
| let | ||
| oneIfA = 1 <$ string "a" <?> "Letter was 'a'" | ||
| zeroIfNotA = 0 <$ regex "[^a]" <?> "Letter was not 'a'" | ||
| letterIsOneOrZero = oneIfA <|> zeroIfNotA <?> | ||
| "The impossible happened: \ | ||
| \a letter was not 'a', and was not not-'a'." | ||
| convertLettersToList = many1 letterIsOneOrZero | ||
| {- | ||
| list <- convertLettersToList -} |
There was a problem hiding this comment.
Don't know if we should fully remove unused code found here and in other locations in this file
There was a problem hiding this comment.
I think it should be removed if it's unused (unless specifically commented out with a TODO or something).
There was a problem hiding this comment.
The point of this comment was to clarify what the below code is doing in a more piece-meal way.
There was a problem hiding this comment.
Jordan, do you prefer it remains commented out or removed? Whatever your choice we can then merge and release.
There was a problem hiding this comment.
I'd prefer it stay commented out.
Description of the change
Fixes spago warnings when building and running tests for this library locally.
Checklist: