Skip to content

Fix transitive dependencies errors in spago 0.20.0 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2021
Merged

Fix transitive dependencies errors in spago 0.20.0 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
668b848
Fix transitive dependencies errors in spago 0.20.0
milesfrain May 10, 2021
62143b3
update changelog
milesfrain May 10, 2021
177a3b8
comment-out unused code
milesfrain May 10, 2021
9f1ad41
Update CHANGELOG.md
thomashoneyman May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ New features:
Bugfixes:

Other improvements:
- Fix transitive dependencies errors found by Spago 0.20 (#71 by @milesfrain)

## [v6.0.0](https://github.com/purescript-contrib/purescript-string-parsers/releases/tag/v6.0.0) - 2021-02-26

Expand Down
4 changes: 3 additions & 1 deletion spago.dhall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,16 @@
, "control"
, "effect"
, "either"
, "enums"
, "foldable-traversable"
, "lists"
, "math"
, "maybe"
, "nonempty"
, "prelude"
, "psci-support"
, "strings"
, "tailrec"
, "unfoldable"
]
, packages = ./packages.dhall
, sources = [ "src/**/*.purs", "test/**/*.purs" ]
Expand Down
2 changes: 1 addition & 1 deletion test/Examples.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ exampleContent1 =

numberOfAs :: Parser Int
numberOfAs = do
{-
let
oneIfA = 1 <$ string "a" <?> "Letter was 'a'"
zeroIfNotA = 0 <$ regex "[^a]" <?> "Letter was not 'a'"
letterIsOneOrZero = oneIfA <|> zeroIfNotA <?>
"The impossible happened: \
\a letter was not 'a', and was not not-'a'."
convertLettersToList = many1 letterIsOneOrZero
{-
list <- convertLettersToList -}
Comment on lines +45 to 53
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we should fully remove unused code found here and in other locations in this file

Copy link
Contributor

@thomashoneyman thomashoneyman May 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed if it's unused (unless specifically commented out with a TODO or something).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this comment was to clarify what the below code is doing in a more piece-meal way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jordan, do you prefer it remains commented out or removed? Whatever your choice we can then merge and release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it stay commented out.

list <- many1
( (1 <$ string "a")
Expand Down