-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
Thanks for kick-starting these updates @garyb. I think they look good. I have some parallel changes (nothing major), but I can merge them in after you're ready with this PR. Regarding using promises, I could really go either way. I think either a callback-based One question I had was about the This doesn't pose an issue for |
Ah, that's an excellent point with the globbing syntax - I suppose we probably should validate the globs and at least raise a warning if it looks like the pattern is unsuitable. Perhaps for now we just make it work though, and then refine later. I suspect most people won't be using anything more advanced than the |
Ok, this is mostly ready now, I've ham-fisted my way through most of the changes, but there's some things I couldn't quite figure out how to do:
Would you mind having a look when you get a minute? Hopefully it'll be a quick change for someone who knows what they're doing 😄 |
Awesome! Thank you for the updates. I will take a look at the streaming. By the way, what do you think of renaming |
Sounds good to me 👍 |
Migrating back to a stream implementation for the tasks to allow conventient piping with other streams such as `gulp.dest`.
Merging stream refactoring for 0.7 updates.
I had the version set as |
Will do. Thanks for the heads up. |
This isn't ready yet, but I wanted to see what you thought @ethul
Changes involved: removal of
psc
, renamedpscMake
topsc
, addedsrc
option for accepting source file globs rather than the previous stream of files from gulp.Since we don't have a stream anymore, I wrapped the task in a
Promise
instead, as this way you can still use it in gulp tasks without having to manually pipe callbacks in with the task definition. This part in particular I wonder if you have any thoughts on - maybe there's a better way? Also I just usedpromise
from npm for this, butq
,bluebird
, etc. would work too, if you have a preference.Still to do: add a task for
pscBundle
, updatedotPsci
andpscDocs
(if needed), remove a bunch of now uneeded stream-related stuff.