Skip to content

Update Concurrent.js #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

i-am-the-slime
Copy link
Member

✘ [ERROR] The symbol "createRoot" has already been declared

    output/React.Basic.DOM.Concurrent/foreign.js:6:16:
      6 │ export function createRoot(element) {
        ╵                 ~~~~~~~~~~

  The symbol "createRoot" was originally declared here:

    output/React.Basic.DOM.Concurrent/foreign.js:2:6:
      2 │ const createRoot = ReactDOM.createRoot || ReactDOM.unstable_createRoot;
        ╵       ~~~~~~~~~~

@i-am-the-slime
Copy link
Member Author

Funnily esbuild does not work with server.js but only server because there's a module definition.

Error in Console:
Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".
@andys8
Copy link
Member

andys8 commented Jul 6, 2022

Cool, would solve the second issue mentioned in #42 (comment)

@andys8 andys8 mentioned this pull request Jul 7, 2022
@mjrussell
Copy link
Member

@i-am-the-slime we can close this now that #44 is merged right?

@i-am-the-slime i-am-the-slime deleted the patch-3 branch July 8, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants