Skip to content

React v18 ReactDOMClient #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Jul 7, 2022

Changes

  • Update react dependency to v18, PureScript to 0.15.4 (package-lock.json)
  • Mark old render functions as deprecated
  • Add ReactDOMClient
  • Delete Concurrent

References

Tests

I was thinking about adding tests, but because they're executed with node (which needs faking a browser) we're not winning much here. I did try out the current branch and it seemed to work fine for the good case: andys8/type-signature-com@51ad716

Warning

There is a handful of older functions that are still working, but will result in a deprecation warning. I ended up adding a deprecation warning to these in ReactDOM.

image

Related

@i-am-the-slime
Copy link
Member

Very nice!

@mjrussell
Copy link
Member

Thank you @andys8! Really appreciate this and thanks especially for adding the warnings for the deprecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants