Update for GitHub Actions #70
Conversation
bower.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| ], | |||
| "repository": { | |||
| "type": "git", | |||
| "url": "git://github.com/paf31/purescript-canvas.git" | |||
| "url": "https://github.com/paf31/purescript-canvas.git" | |||
There was a problem hiding this comment.
Should this be updated to purescript-web1 rather than paf31?
There was a problem hiding this comment.
ping @thomashoneyman
There was a problem hiding this comment.
Oops, sorry. Looks like this package is here in the registry:
...which seems to be purescript/ rather than purescript-web/. @f-f may know for sure, but I think this URL just needs to match the registry so we can publish new versions.
package.json
Outdated
| @@ -6,9 +6,9 @@ | |||
| "test": "pulp test" | |||
There was a problem hiding this comment.
CI is failing because of this line. We are using npm run-script test --if-present. NPM finds that there is such a script (above) and executes it. However, there aren't any tests in this repo. I'm assuming we should drop this 'test' script here?
There was a problem hiding this comment.
Yea, that works. Thanks!
There aren't any tests in this repo. If we want to add them later, this script should be added again.
|
|
||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: "10" |
There was a problem hiding this comment.
Is there a specific reason for this version and not "12" like in the core libraries?
There was a problem hiding this comment.
The core libraries were updated before our discussion about the minimum supported node version (10), which will switch to 12 in March. We don’t use any features that are different between the versions so we could use either of these two; I opted to update libraries going forward to use v10 but to leave the libraries already on v12 as they are.
There was a problem hiding this comment.
Oh I thought the discussion was only for the purescript-node libraries. I’m relieved this is not something to change on the whole org then 😅
There was a problem hiding this comment.
Yea me too 😅 we’ll just be sure to have those on 10, and in general we should try to use 10, and in the future we will have to update to 12. Unless there’s an easy way with setup-node to automatically target the last supported version.
|
Can I get feedback on my comment here about the URL being different now? |
|
Sorry about that, @JordanMartinez. I've responded and made the relevant update. |
|
Thanks! |
This PR updates
canvasto use the same standard README format as the rest of-web, and migrates to use GitHub Actions for CI.