Update for GitHub Actions #70
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
| branches: [master] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: purescript-contrib/setup-purescript@main | ||
|
|
||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: "10" | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| npm install -g bower | ||
| npm install | ||
| bower install --production | ||
|
|
||
| - name: Build source | ||
| run: npm run-script build | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| bower install | ||
| npm run-script test --if-present | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,7 @@ bower_components/ | |
| package-lock.json | ||
|
|
||
| /.* | ||
| !/.github | ||
| !/.gitignore | ||
|
|
||
| *.db | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,17 @@ | ||
| # purescript-canvas | ||
|
|
||
| [](https://github.com/purescript-web/purescript-canvas/releases) | ||
| [](https://github.com/purescript-web/purescript-canvas/actions?query=workflow%3ACI+branch%3Amaster) | ||
| [](https://pursuit.purescript.org/packages/purescript-canvas) | ||
|
|
||
| Canvas bindings for PureScript. | ||
|
|
||
| ## Installation | ||
|
|
||
| ``` | ||
| spago install canvas | ||
| ``` | ||
|
|
||
| ## Documentation | ||
|
|
||
| Module documentation is [published on Pursuit](http://pursuit.purescript.org/packages/purescript-canvas). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| ], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/paf31/purescript-canvas.git" | ||
|
There was a problem hiding this comment. Should this be updated to There was a problem hiding this comment. ping @thomashoneyman There was a problem hiding this comment. Oops, sorry. Looks like this package is here in the registry: ...which seems to be |
||
| }, | ||
| "dependencies": { | ||
| "purescript-effect": "^2.0.0", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for this version and not
"12"like in the core libraries?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core libraries were updated before our discussion about the minimum supported node version (10), which will switch to 12 in March. We don’t use any features that are different between the versions so we could use either of these two; I opted to update libraries going forward to use v10 but to leave the libraries already on v12 as they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought the discussion was only for the purescript-node libraries. I’m relieved this is not something to change on the whole org then 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea me too 😅 we’ll just be sure to have those on 10, and in general we should try to use 10, and in the future we will have to update to 12. Unless there’s an easy way with setup-node to automatically target the last supported version.