Skip to content

Make autocomplete take/return a String #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2022
Merged

Make autocomplete take/return a String #72

merged 4 commits into from
Apr 27, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #56

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Apr 27, 2022
@JordanMartinez
Copy link
Contributor Author

Hm... Looks like I forgot to merge this or something...

@JordanMartinez JordanMartinez merged commit c02e025 into purescript-web:master Apr 27, 2022
@JordanMartinez JordanMartinez deleted the fix-autocomplete branch April 27, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute "autocomplete" is a String -- not a Boolean
2 participants
@JordanMartinez @thomashoneyman