Skip to content

Make autocomplete take/return a String #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Make autocomplete take/return a String #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40f79c8
Make autocomplete take/return a String
JordanMartinez Mar 25, 2022
e5ffa3e
Add changelog entry for ps 0.15.0 update
JordanMartinez Mar 25, 2022
4d4e8d2
Add changelog entry for this PR
JordanMartinez Mar 25, 2022
9b3f842
Merge branch 'master' into fix-autocomplete
thomashoneyman Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes:
- Migrate FFI to ES modules (#71 by @JordanMartinez)
- Make `autocomplete` take a `String` arg, not Boolean (#72 by @JordanMartinez)
- Move `getBoundingClientRect` to `purescript-web-dom` (#73 by @JordanMartinez)

New features:
Expand Down
4 changes: 2 additions & 2 deletions src/Web/HTML/HTMLInputElement.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ foreign import setAccept :: String -> HTMLInputElement -> Effect Unit
foreign import alt :: HTMLInputElement -> Effect Boolean
foreign import setAlt :: Boolean -> HTMLInputElement -> Effect Unit

foreign import autocomplete :: HTMLInputElement -> Effect Boolean
foreign import setAutocomplete :: Boolean -> HTMLInputElement -> Effect Unit
foreign import autocomplete :: HTMLInputElement -> Effect String
foreign import setAutocomplete :: String -> HTMLInputElement -> Effect Unit

foreign import autofocus :: HTMLInputElement -> Effect Boolean
foreign import setAutofocus :: Boolean -> HTMLInputElement -> Effect Unit
Expand Down