Update core.py #45
Closed
Update core.py #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a minimum chain length from all chains
|
Did you close it on purpose? I'm thinking about introducing a Will do this some time today once I get the chance. |
|
oops sorry, didn't do this on purpose! Yes, its probably better to introduce a boolean flag for this! |
|
Okay, so as far as I understand you're "unblocked" right now so there's no immediate time pressure, right? If you can spend some time (sounds like your model is going to run for a few weeks now 😄) you're welcome to implement the boolean flag :) Otherwise, as I said, I'll get it done within the next 3 days. |
|
This got replaced by #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a minimum chain length calculated from all chains