-
Notifications
You must be signed in to change notification settings - Fork 6
boolean flag for chain length #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nitpicks, but thanks for the PR !
Please run the pre-commit which will normalize some whitespace stuff and thereby fix the CI tests:
pip install pre-commit
pre-commit run --all
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'm always up for suggestions. Not a super strong git user myself, neither a programmer (more of a scientific programmer..) so I'm always aware i might be doing things wrong :) I usually use pychanrm which takes care of whitespace, but this time I did it manually. Hope i'm doing the right thing here, I can only comment on the changes (I cant approve..)
perhaps trivial question, but I run the pre-comit and then make a new merge request? |
not a new merge request - the precommit makes the changes and then you commit them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good!
I'll publish a patch release later today.
Boolean flag defaults to true and truncates chains to minimum chain length