Skip to content

boolean flag for chain length #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2022

Conversation

shakasaki
Copy link
Contributor

Boolean flag defaults to true and truncates chains to minimum chain length

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpicks, but thanks for the PR !

Please run the pre-commit which will normalize some whitespace stuff and thereby fix the CI tests:

pip install pre-commit
pre-commit run --all

shakasaki and others added 4 commits August 11, 2022 13:45
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Copy link
Contributor Author

@shakasaki shakasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'm always up for suggestions. Not a super strong git user myself, neither a programmer (more of a scientific programmer..) so I'm always aware i might be doing things wrong :) I usually use pychanrm which takes care of whitespace, but this time I did it manually. Hope i'm doing the right thing here, I can only comment on the changes (I cant approve..)

@shakasaki
Copy link
Contributor Author

perhaps trivial question, but I run the pre-comit and then make a new merge request?

@michaelosthege
Copy link
Member

not a new merge request - the precommit makes the changes and then you commit them

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

I'll publish a patch release later today.

@michaelosthege michaelosthege merged commit a5c1aae into pymc-devs:main Aug 11, 2022
@michaelosthege michaelosthege mentioned this pull request Aug 11, 2022
@shakasaki shakasaki deleted the chain-length-branch branch August 11, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants