boolean flag for chain length #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
requested changes
Aug 11, 2022
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
shakasaki
commented
Aug 11, 2022
There was a problem hiding this comment.
sure, I'm always up for suggestions. Not a super strong git user myself, neither a programmer (more of a scientific programmer..) so I'm always aware i might be doing things wrong :) I usually use pychanrm which takes care of whitespace, but this time I did it manually. Hope i'm doing the right thing here, I can only comment on the changes (I cant approve..)
|
perhaps trivial question, but I run the pre-comit and then make a new merge request? |
|
not a new merge request - the precommit makes the changes and then you commit them |
michaelosthege
approved these changes
Aug 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean flag defaults to true and truncates chains to minimum chain length