Skip to content

Update ppc test #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Update ppc test #4246

merged 1 commit into from
Nov 23, 2020

Conversation

ColCarroll
Copy link
Member

I think this will unstick @StephenHogg in #4211.

My working theory is that this was asserting that 2 arrays of 20,000 floats were equal, after going through a couple arithmetic operations, and so it was essentially fuzzing theano's math library. I can't prove that, but this

  • makes the fuzzing less thorough (2,000 floats now), and
  • lowers the number of operations (I don't go through a pandas dataframe in the middle, since I feel like that might do wild things to the floats).
  • Added an extra seed before each ppc sampling, since two of the asserts should give the exact same results.

Also, I changed assert np.allclose to npt.assert_allclose, since it gives more pleasant stack traces.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #4246 (bd7e1d9) into master (b990e49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4246   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files          89       89           
  Lines       14358    14358           
=======================================
  Hits        12663    12663           
  Misses       1695     1695           

Copy link
Member

@Spaak Spaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; although I'm not sure why the pandas dataframe was there to begin with?

@ColCarroll ColCarroll merged commit 68d5201 into pymc-devs:master Nov 23, 2020
@ColCarroll
Copy link
Member Author

Also not sure. Maybe for coverage? It is still in a few other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants