Skip to content

expand_dims eager optimization #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

HangenYuu
Copy link
Contributor

Description

A small eager optimization to avoid useless dimshuffles in expand_dims, follwing squeeze logic.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94
Copy link
Member

@HangenYuu you seem to have started this from a branch other than main (it includes a lot of unrelated commits, from your other PR)

@HangenYuu
Copy link
Contributor Author

Oh. I created a new branch from the main branch but turn out it's of my fork. Let me close this and re-fork it properly.

@HangenYuu HangenYuu closed this Apr 17, 2024
@HangenYuu HangenYuu deleted the expand_dims_optimize branch April 25, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid dimshuffle if expand_dims has empty axis
2 participants