-
Notifications
You must be signed in to change notification settings - Fork 130
Avoid dimshuffle if expand_dims has empty axis #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid dimshuffle if expand_dims has empty axis #724
Conversation
@ricardoV94 Updated here from #718. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 80.76% 80.76% -0.01%
==========================================
Files 162 162
Lines 46713 46715 +2
Branches 11426 11427 +1
==========================================
Hits 37729 37729
- Misses 6732 6736 +4
+ Partials 2252 2250 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small tweak
Small request, can you edit the title to be more like the original issue? This is what shows up on the automatic release notes and the current title is completely uninformative for someone only reading it |
Co-authored-by: Ricardo Vieira <[email protected]>
Thanks! I hope the git stuff was not too frustrating |
Description
A small eager optimization to avoid useless
dimshuffle
s inexpand_dims
, follwingsqueeze
logic.Related Issue
Checklist
Type of change