-
Notifications
You must be signed in to change notification settings - Fork 347
Add support for serialized rollback #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there any particular reason for the current Travis-ci configuration only testing against MySQL using Python2.7 + Django 1.11, and not testing against the new versions of django and python3? |
It is meant to have a smaller build matrix. |
Your branch gives me this warning:
This is a very important PR for me, thanks for implementing it! |
e310075
to
c6565b7
Compare
@lapp0 Thanks for pointing me the warnings. I already fix the code. Anyway, a key duplication error is occurring, however, this seems to be erratic behavior since the same commit causes the test suite to fail differently on two different instances of travis-ci https://travis-ci.org/pytest-dev/pytest-django/builds/605222978 |
3a49c05
to
c6565b7
Compare
c6565b7
to
6513f37
Compare
The ticket https://code.djangoproject.com/ticket/26552 was fixed in Django master branch. |
@luzfcb Apart from resolving conflicts and adding tests, is there something else that needs to be done before this is ready for merging? Has someone come up with some kind of a temporary workaround for this problem before this PR is finalized? |
@luzfcb Hi! I found this PR after encountering an error in a large Django test suite and it would be fantastic to count on this feature to solve that problem! |
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
A PR which will replace this PR is in #970. I intend to merge and release it in a few days. Comments and tests are welcome. |
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
Fixes #329.
TODO:
This is the code made by @blueyed in #353 with some additional inspired by #619
This issue reported by @aaugustin seems to be a blocker
https://code.djangoproject.com/ticket/26552