Support Serialized Rollbacks for Databases #919
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
Apr 10, 2021
There was a problem hiding this comment.
Thanks, it mostly looks good to me, I left some comments.
One thing that is not so nice is that (IIUC) django_db_serialized_rollback and django_db_reset_sequences do not compose properly. Making it so will require refactoring the code a bit. If you can make it so that'd be great, if not, I can look at it after the PR is merged.
| @@ -243,6 +253,8 @@ def transactional_db(request, django_db_setup, django_db_blocker): | |||
| """ | |||
| if "django_db_reset_sequences" in request.fixturenames: | |||
| request.getfixturevalue("django_db_reset_sequences") | |||
| if "django_db_serialized_rollback" in request.fixturenames: | |||
There was a problem hiding this comment.
Need to add django_db_serialized_rollback to the docstring above.
Comment on lines
+281
to
+286
| """Enable serialized rollback after transaction test cases | ||
|
|
||
| This fixture only has an effect when the ``transactional_db`` | ||
| fixture is active, which happen as a side-effect of requesting | ||
| ``live_server``. | ||
|
|
There was a problem hiding this comment.
Suggested change
| """Enable serialized rollback after transaction test cases | |
| This fixture only has an effect when the ``transactional_db`` | |
| fixture is active, which happen as a side-effect of requesting | |
| ``live_server``. | |
| """Enable serialized rollback after transactional tests. | |
| This fixture only has an effect when the :fixture:`transactional_db` | |
| fixture is active, which happen as a side-effect of requesting | |
| :fixture:`live_server`. |
| @@ -218,13 +225,16 @@ def db(request, django_db_setup, django_db_blocker): | |||
| """ | |||
| if "django_db_reset_sequences" in request.fixturenames: | |||
| request.getfixturevalue("django_db_reset_sequences") | |||
| if "django_db_serialized_rollback" in request.fixturenames: | |||
There was a problem hiding this comment.
Need to add it to the docstring above.
| class ResetSequenceTestCase(django_case): | ||
| reset_sequences = True | ||
|
|
||
| django_case = ResetSequenceTestCase | ||
|
|
||
| if serialized_rollback: | ||
| class SerializedRollbackTestCase(django_case): |
There was a problem hiding this comment.
Creating another subclass seems unnecessary. I will combine with the above (can call it PytestDjangoTestCase).
| :type serialized_rollback: bool | ||
| :param serialized_rollback: | ||
| The ``serialized_rollback`` argument enables `rollback emulation`_. | ||
| After a `django.test.TransactionTestCase`_ runs, the database is |
There was a problem hiding this comment.
Suggested change
| After a `django.test.TransactionTestCase`_ runs, the database is | |
| After a :class:`django.test.TransactionTestCase` runs, the database is |
| After a `django.test.TransactionTestCase`_ runs, the database is | ||
| flushed, destroying data created in data migrations. This is the | ||
| default behavior of Django. Setting ``serialized_rollback=True`` | ||
| tells Django to restore that data. |
There was a problem hiding this comment.
Need to mention django_db_serialized_rollback in the paragraph below.
| marker applied in order to access the database. | ||
|
|
||
| .. _rollback emulation: https://docs.djangoproject.com/en/stable/topics/testing/overview/#rollback-emulation | ||
| .. _django.test.TestCase: https://docs.djangoproject.com/en/dev/topics/testing/overview/#testcase |
There was a problem hiding this comment.
intersphinx references should be used when possible (see my example suggestion above,
:class:`django.test.TransactionTestCase`
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Nov 29, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
|
A PR which will replace this PR is in #970. I intend to merge and release it in a few days. Comments and tests are welcome. |
bluetech
added a commit
to bluetech/pytest-django
that referenced
this pull request
Dec 1, 2021
Thanks to Aymeric Augustin, Daniel Hahler and Fábio C. Barrionuevo da Luz for previous work on this feature. Fix pytest-dev#329. Closes pytest-dev#353. Closes pytest-dev#721. Closes pytest-dev#919. Closes pytest-dev#956.
bluetech
added a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for serialized rollbacks for databases. It's mostly taken directly from #721 and has been updated to mergable with the current HEAD.
Opening this as draft initially to run CI.
Fixes #329