Update CONTRIBUTING.md and New Contributors Guide to reflect that anyone can merge PRs after checks and approvals #10123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10123
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3eb0193 with merge base eeabc29 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jhelsby
changed the title
|
@pytorchbot label "topic: not user facing" |
byjlw
approved these changes
Apr 11, 2025
|
@pytorchbot cherry-pick --onto release/0.6 -c docs |
Cherry picking #10123Command Details for Dev Infra teamRaised by workflow job |
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…one can merge PRs after checks and approvals (pytorch#10123) ### Summary As discussed in [this PR](pytorch#10118), anyone can merge PRs once approved and all CI checks have passed. `CONTRIBUTING.md` was outdated, saying only people with write-access could merge. This change: * Updates CONTRIBUTING.md to reflect the fact anyone can merge their PR after required approvals and checks. * Adds step-by-step instructions on this to the New Contributors Guide. --------- Co-authored-by: jhels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in this PR, anyone can merge PRs once approved and all CI checks have passed.
CONTRIBUTING.mdwas outdated, saying only people with write-access could merge.This change: