-
Notifications
You must be signed in to change notification settings - Fork 2k
Update instruction for setting up TD2 on Compute Modules #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Something wrong here - will sort out tomorrow. |
Update instruction for setting up TD2 on Compute Modules Typo Add information on setting up TD2 on Compute modules Updated from review comments Updated after review comments URL fixup Hopefully last fixup from review comments
225cee9
to
2d237cb
Compare
OK, sorted out all the merge issues. I think this is ready to go. |
documentation/asciidoc/computers/compute-module/cmio-display.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but pinging @6by9 for one final check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioning J6 should be in there, but feel free to ignore the other two comments.
Unrelated, but rereading that page has also made me note that https://www.raspberrypi.com/documentation/computers/compute-module.html#connect-one-camera says dtoverlay=ov5647,cam1
etc.
There is no cam1
override, only cam0
. Using cam1 is the default, and the firmware will be logging that cam1
is an unknown override.
documentation/asciidoc/computers/compute-module/cmio-display.adoc
Outdated
Show resolved
Hide resolved
|
||
Touch Display 2 is a 720x1280 7" LCD display designed specifically for Raspberry Pi devices (see https://www.raspberrypi.com/products/touch-display-2/). It connects in the same way as the original touch display, but the software setup on Compute Modules is slightly different as it uses a different display driver. See xref:../accessories/touch-display-2.adoc[Touch Display 2] for connection details. | ||
|
||
Edit the /boot/firmware/config.txt file and add the following to enable Touch Display 2 on DISP1/DSI1. You will also need to add jumpers to J6 as indicated on the silkscreen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the earlier TD1 instructions, is this J6 jumper specific to CM4 IO board? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CM4IO J6 connects I2C to CAM0 and DISP0
CM5IO J6 connects I2C to CAM/DISP1.
No comment on consistency!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its J6 on both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and we probably also want CM 1 / 3 / 4S hookup instructions for TD2?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the jumper settings etc. identical for TD1 and TD2? In which case perhaps the "You will also need to add jumpers to J6 as indicated on the silkscreen." phrase here should be removed, and replaced with something like "See the earlier Touch Display instructions for details of required jumper settings." ?
Or (as a bigger change) perhaps it worth separating out the electrical-hookup instructions (jumpers etc.) which are the same for both TD1 and TD2, from the config.txt
instructions which are different for TD1 and TD2? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the jumper settings etc. identical for TD1 and TD2
Yes. It's a board level thing, not what display is connected.
Remove unnecessary `cam1` directives, as detailed in #4084 (review)
Supercedes #4072