Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update instruction for setting up TD2 on Compute Modules #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update instruction for setting up TD2 on Compute Modules #4084
Changes from all commits
2d237cb
e16b709
bc19de2
9d1d7cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the earlier TD1 instructions, is this J6 jumper specific to CM4 IO board? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CM4IO J6 connects I2C to CAM0 and DISP0
CM5IO J6 connects I2C to CAM/DISP1.
No comment on consistency!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its J6 on both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and we probably also want CM 1 / 3 / 4S hookup instructions for TD2?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the jumper settings etc. identical for TD1 and TD2? In which case perhaps the "You will also need to add jumpers to J6 as indicated on the silkscreen." phrase here should be removed, and replaced with something like "See the earlier Touch Display instructions for details of required jumper settings." ?
Or (as a bigger change) perhaps it worth separating out the electrical-hookup instructions (jumpers etc.) which are the same for both TD1 and TD2, from the
config.txt
instructions which are different for TD1 and TD2? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's a board level thing, not what display is connected.