-
Notifications
You must be signed in to change notification settings - Fork 181
Add original English explicit heading IDs to everything #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generate explicit IDs for headings.
@smikitky thanks for finding all those errors >_< How are you able to find them? Whenever I try to look at the diff on github everything just freezes up! |
Oh, thank you. Did you use some script to do this? I removed one conflict and one punctuation error. Textlint is complaining because we expect fullwidth space after a fullwidth exclamation mark:
But I believe this is an error on the textlint's side. We may have to disable this rule temporarily because this should be merged promptly. @potato4d @koba04 What do you think? |
@tesseralis I'm using vscode-pull-request to check the diff on my PC! |
I did use some script to do it 😛 Also I should check vscode-pull-request! Thanks for being on top of this as always 🙏 |
I took the liberty to disable the two textlint rules that were causing trouble. IMHO, these rules have not been working correctly anyway, and we should introduce our own rule. (#20) |
@smikitky It's very important that we don't do a squash commit here or else git won't register the original commits and doing another sync will cause errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@smikitky since I was the one who didn't figure this out until late I figured it was my responsibility to fix it :P