Skip to content

Add original English explicit heading IDs to everything #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 8, 2019

Conversation

tesseralis
Copy link
Member

@smikitky since I was the one who didn't figure this out until late I figured it was my responsibility to fix it :P

@tesseralis tesseralis requested review from koba04 and smikitky February 8, 2019 00:51
@tesseralis tesseralis changed the title Add original English headings to everything Add original English explicit heading IDs to everything Feb 8, 2019
@tesseralis
Copy link
Member Author

@smikitky thanks for finding all those errors >_< How are you able to find them? Whenever I try to look at the diff on github everything just freezes up!

@smikitky
Copy link
Member

smikitky commented Feb 8, 2019

Oh, thank you. Did you use some script to do this?

I removed one conflict and one punctuation error.

Textlint is complaining because we expect fullwidth space after a fullwidth exclamation mark:

## 始めましょう! {#lets-get-started}
                ^

But I believe this is an error on the textlint's side. We may have to disable this rule temporarily because this should be merged promptly. @potato4d @koba04 What do you think?

@smikitky
Copy link
Member

smikitky commented Feb 8, 2019

@tesseralis I'm using vscode-pull-request to check the diff on my PC!

@tesseralis
Copy link
Member Author

I did use some script to do it 😛

Also I should check vscode-pull-request! Thanks for being on top of this as always 🙏

@smikitky
Copy link
Member

smikitky commented Feb 8, 2019

I took the liberty to disable the two textlint rules that were causing trouble. IMHO, these rules have not been working correctly anyway, and we should introduce our own rule. (#20)

@tesseralis
Copy link
Member Author

@smikitky It's very important that we don't do a squash commit here or else git won't register the original commits and doing another sync will cause errors.

@potato4d
Copy link
Member

potato4d commented Feb 8, 2019

@smikitky

But I believe this is an error on the textlint's side. We may have to disable this rule temporarily because this should be merged promptly. @potato4d @koba04 What do you think?

I think there is no problem.

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tesseralis tesseralis merged commit 8644395 into master Feb 8, 2019
@smikitky smikitky mentioned this pull request Feb 8, 2019
90 tasks
@potato4d potato4d deleted the sync-original branch February 20, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants