Skip to content

Translation of the lifting-state-up in Turkish #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 26, 2019

Conversation

kapozade
Copy link
Contributor

No description provided.

@kapozade kapozade changed the title Translation #part01 of lifting-state-up in Turkish Translation of the lifting-state-up in Turkish Feb 24, 2019
@kapozade kapozade marked this pull request as ready for review February 24, 2019 18:35
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for tr-reactjs ready!

Built with commit c105ca7

https://deploy-preview-19--tr-reactjs.netlify.com

@ozcanzaferayan ozcanzaferayan self-requested a review February 24, 2019 18:43
Change 'ebeveyn' as 'ortak ust eleman' and 'CodePen'de deneyiniz' as 'CodePen'de deneyin'
@alioguzhan
Copy link
Member

Parent and Child words need to be translated as üst and alt. see #21

And (just a recommendation), possible translation for this section's title would be State'i Yukarı Taşımak or State'i Üst Elemana Taşımak

We can discuss it, though.

@kapozade
Copy link
Contributor Author

kapozade commented Feb 26, 2019

@alioguzhan I believe ortak üst eleman will be more clear in lifting-state-up context. Because üst might create ambiguity in this context.

@kapozade
Copy link
Contributor Author

@alioguzhan , I changed the title and some of the context phrases which means parent. You can have a look if you want.

@alioguzhan
Copy link
Member

Hmm. I think we need to behave differently to title and content. The updated version of the title looks better to me now. (State'i Yukari Tasima)

But in the content section, en yakin ortak ust eleman for closest common ancestor looks way better. What do you think?

@kapozade
Copy link
Contributor Author

@alioguzhan yes, you're right. en yakin ortak ust eleman will be better choice for the closest common ancestor. Applied the required changes. Thanks!

Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation! In general, it looks great. To keep consistency and integrity between translations, a more detailed review should be done before the final release, though.

@alioguzhan alioguzhan merged commit a4c853e into reactjs:master Feb 26, 2019
@kapozade kapozade deleted the onurkapcik/lifting-state-up branch March 20, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants