Accessibility

[fatmabadri]

No description provided.

[netlify]

Deploy preview for tr-reactjs ready!

Built with commit 8dcfce1

https://deploy-preview-279--tr-reactjs.netlify.app

[fatmabadri]

Hi @alioguzhan,
Would you make me enable to assign the reviewer and add a label to the PR?

[alioguzhan]

Hi @fatmabadri

You don't need to make assignments. Since we are only 2 (@yunusemredilber and I), we can manage that process internally. Thanks for your interest.

[yunusemredilber]

I have one more suggestion. I think there are a lot more commits than necessary for this translation. To keep the commit history clear, It might make sense to do "Squash and Merge" at the end. What do you think @alioguzhan ?

[alioguzhan]

Yes. That makes sense. Let's squash and merge once this is ready to merge @yunusemredilber

Since you are translating one document, it is better if you keep it under one commit or two (with later updates). @fatmabadri

[fatmabadri]

Hi @fatmabadri

You don't need to make assignments. Since we are only 2 (@yunusemredilber and I), we can manage that process internally. Thanks for your interest.

Hi @alioguzhan. I have asked to be enabled to add the reviewer myself when making a PR not to make an assignment or something else. This is my last translation. I am not interested to join you internally since you are only two people, managed to the end and the Turkish translation is almost done. Thank you.

[alioguzhan]

@fatmabadri I thought you were mentioning picking a user from maintainers to review this PR. I didn't think that you would want to assign yourself as a reviewer to your own Pull Request.

Someone else has to be a reviewer for our own PR's. A second or third eye re-views the work that has been done and checks if this is appropriate to be merged. This is the idea about Pull Request and Review process.

Thanks for your work and translation. I will review it as soon as I have some spare time.

[fatmabadri]

@fatmabadri I thought you were mentioning picking a user from maintainers to review this PR. I didn't think that you would want to assign yourself as a reviewer to your own Pull Request.

Someone else has to be a reviewer for our own PR's. A second or third eye re-views the work that has been done and checks if this is appropriate to be merged. This is the idea about Pull Request and Review process.

Thanks for your work and translation. I will review it as soon as I have some spare time.

@alioguzhan,
You have misunderstood. I asked to be enabled to add the reviewer myself, I did not say to add myself as a reviewer. I intended to add the maintainer while a PR was being made.
I cannot be the reviewer of my own translation. There is no point to do that. Absolutely, my translation has to be reviewed by the maintainer as they are the ones responsible and have more experience to do this. I hope it is clear now. And also thank you for your time.

[fatmabadri]

Yes. That makes sense. Let's squash and merge once this is ready to merge @yunusemredilber

Since you are translating one document, it is better if you keep it under one commit or two (with later updates). @fatmabadri

It is one document but it is a quite long one. Translations were made in the different days. Multiple commits were done in order to keep the translated part protected . @alioguzhan

[alioguzhan]

Yes. That makes sense. Let's squash and merge once this is ready to merge @yunusemredilber
Since you are translating one document, it is better if you keep it under one commit or two (with later updates). @fatmabadri

It is one document but it is a quite long one. Translations were made in the different days. Multiple commits were done in order to keep the translated part protected . @alioguzhan

It is totally fine if this is your preferred way. As I said, we can squash and merge. No problem at all.

@alioguzhan,
You have misunderstood. I asked to be enabled to add the reviewer myself, I did not say to add myself as a reviewer. I intended to add the maintainer while a PR was being made.

I see. So this brings us to my previous answer. Since we do not know who is available or not, It becomes uncertain who will be reviewing some particular PR. If the contributors would have permission to add reviewers, it would be a demand more than an assignment. And this is a concept we don't have here. In our case, I or @yunusemredilber are assigning ourselves. Or we mention each other in a comment by asking kindly if he can review this or not.

Sorry for the misunderstanding.

[alioguzhan]

Thanks for the translation. See my comments, please.

[alioguzhan]

Thanks for the translation. (Forgot to write this message earlier today)