Skip to content

Translation API Reference > test utilities #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 13, 2019
Merged

Translation API Reference > test utilities #37

merged 7 commits into from
Mar 13, 2019

Conversation

kapozade
Copy link
Contributor

@kapozade kapozade commented Mar 5, 2019

Hi,

Please review the document. Let me know about the possible improvements or the unintended misleading contexts.

Thanks.

@kapozade kapozade changed the title Onurkapcik/test utilities Translation API Reference > test utilities Mar 5, 2019
@netlify
Copy link

netlify bot commented Mar 5, 2019 •
edited
Loading

Deploy preview for tr-reactjs ready!

Built with commit 7364860

https://deploy-preview-37--tr-reactjs.netlify.com

@kapozade kapozade force-pushed the onurkapcik/test-utilities branch from 06384a6 to b10cb96 Compare March 5, 2019 11:51
helloanil
helloanil suggested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@helloanil helloanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. I'll also keep reviewing later. Please let me know what you think of my comments.

@kapozade kapozade force-pushed the onurkapcik/test-utilities branch from 93430b6 to 2b1635c Compare March 5, 2019 15:31
@kapozade
Copy link
Contributor Author

kapozade commented Mar 5, 2019

@helloanil , thanks for the inputs. I applied the change requests.

Thanks.

@tesseralis tesseralis mentioned this pull request Mar 5, 2019
Closed
94 tasks
ozcanzaferayan
ozcanzaferayan suggested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@ozcanzaferayan ozcanzaferayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onur merhaba,
Öncelikle çevirin için teşekkürler. Güzel bir yazı olmuş.
Review ederken karşılaştığım kısımları ekledim.
Kolay gelsin.

@kapozade
Copy link
Contributor Author

kapozade commented Mar 9, 2019

Hello @ozcanzaferayan ,

Thanks for the recommendations, I agree with your change requests. I adapted changes in a way you recommended.

@alioguzhan alioguzhan merged commit e8abb14 into reactjs:master Mar 13, 2019
@kapozade kapozade deleted the onurkapcik/test-utilities branch March 20, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alioguzhan alioguzhan alioguzhan left review comments

@helloanil helloanil helloanil requested changes

@ozcanzaferayan ozcanzaferayan ozcanzaferayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapozade @ozcanzaferayan @alioguzhan @helloanil