Skip to content

translate Refs and the DOM #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 17, 2019
Merged

translate Refs and the DOM #83

merged 5 commits into from
Apr 17, 2019

Conversation

SafaElmali
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 24, 2019 •
edited
Loading

Deploy preview for tr-reactjs ready!

Built with commit 7c7ee08

https://deploy-preview-83--tr-reactjs.netlify.com

@alioguzhan alioguzhan changed the title first paragraph translation of refs translate Refs and the DOM Mar 24, 2019
@alioguzhan
Copy link
Member

Hey, thanks for the contribution.

Can you please read the basic rules on #1 for contribution and commit message styles. Also, it would be better if you leave a comment below with the name of the page you would like to translate so that we can add you to the list.

Thanks.

@tesseralis tesseralis mentioned this pull request Mar 25, 2019
Closed
94 tasks
@alioguzhan alioguzhan added the work in progress This still needs some work label Mar 25, 2019
@alioguzhan
Copy link
Member

Hey @SafaElmali , any update on this? If you don't have time we can re-assign it to someone else. Thanks

@SafaElmali
Copy link
Contributor Author

Hey @SafaElmali , any update on this? If you don't have time we can re-assign it to someone else. Thanks

I will commit it soon. Sorry for delay.

@SafaElmali
Copy link
Contributor Author

Could you please check the missing parts? I wasn't sure for those parts. That's why I didn't translate. @alioguzhan

@alioguzhan
Copy link
Member

Could you please check the missing parts? I wasn't sure for those parts. That's why I didn't translate. @alioguzhan

Ok, I will check those parts in a few days. I'll let you know. Thanks

@alioguzhan alioguzhan self-requested a review April 16, 2019 07:11
alioguzhan
alioguzhan requested changes Apr 16, 2019
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation. Please see the reviews.

@alioguzhan
Copy link
Member

You missed some parts from my last review. Can you please check all of them. Thanks! @SafaElmali

@alioguzhan
Copy link
Member

Thanks. Merging it...

@alioguzhan alioguzhan merged commit 28d9ecb into reactjs:master Apr 17, 2019
@alioguzhan alioguzhan removed the work in progress This still needs some work label Apr 17, 2019
@SafaElmali
Copy link
Contributor Author

Thanks. Merging it...

Thank you! and sorry for my translating mistakes 😬

@alioguzhan
Copy link
Member

Thanks. Merging it...

Thank you! and sorry for my translating mistakes 😬

No worries! We all are trying to contribute, with good intentions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alioguzhan alioguzhan alioguzhan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SafaElmali @alioguzhan