Cleanup completion details docs #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Mar 11, 2024
| @@ -74,20 +74,20 @@ Resolved opens 1 pervasives | |||
| "label": "version", | |||
| "kind": 5, | |||
| "tags": [], | |||
| "detail": "version?: int\n\ntype jsxConfig = {version: int, module_: string, mode: string}", | |||
| "documentation": null | |||
| "detail": "int", | |||
There was a problem hiding this comment.
change in detail intentional?
zth
force-pushed
the
cleanup-completion-details-docs
branch
from
0d70ec7 to
9b80982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469 and #837
This does 2 things:
completionResolverequest so we can resolve (some) completion item docs async. Then via that implement file module docs resolution.This is a big diff test wise, because I've changed quite a few things wrt details and docs. It might not all be perfect yet, but it's going to be much much better than what we have today already, given what mess the details and docs for completion items are today.
Example of file module level docs:
