Skip to content

[rrppx] Add error when using non-optional type to define an optional arg #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

[rrppx] Add error when using non-optional type to define an optional arg #4128

merged 1 commit into from
Feb 1, 2020

Conversation

rickyvetter
Copy link
Contributor

Fixes #4099

@bobzhang
Copy link
Member

hi @rickyvetter it seems you need update submodule ocaml to avoid diffs.
can you also check JakubMarkiewicz/reason-transition-group#5
so that it can be batched together

@rickyvetter
Copy link
Contributor Author

Updated for OCaml weirdness! JakubMarkiewicz/reason-transition-group#5 is a legitimate error that should've been caught before.

@bobzhang bobzhang merged commit 2749941 into rescript-lang:master Feb 1, 2020
@romanschejbal
Copy link
Contributor

romanschejbal commented Feb 5, 2020 •
edited
Loading

Hello guys, just a quick question - isn't this is a breaking change? It broke a few dependencies for us 😄

@bobzhang
Copy link
Member

cc @rickyvetter would you update the changes.md

@nirvdrum nirvdrum mentioned this pull request Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional parameters with defined type not wrapping it with option variant.
3 participants
@rickyvetter @bobzhang @romanschejbal