Skip to content

fix #4135 better parallelism making use of -opaque #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2020
Merged

fix #4135 better parallelism making use of -opaque #4136

merged 2 commits into from
Feb 1, 2020

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Feb 1, 2020

No description provided.

@bobzhang bobzhang changed the title add a note on warning fix #4135 better parallelism making use of -opaque Feb 1, 2020
@bobzhang bobzhang merged commit d92f9a0 into master Feb 1, 2020
@bobzhang bobzhang deleted the opaque_parallelism branch February 1, 2020 09:49
@nirvdrum
Copy link

In case anyone else runs into this, the various Location.raise_errorf ~loc:pattern.ppat_loc "ReasonReact: optional argument annotations must have explicit `option`. Did you mean `option(%s)=?`?" currentType) introduce a bug fix that may make upgrading from <= 7.0.2-dev.1 difficult. In my case, this change raises new errors that previously went through in the bs-alt-design package. Catching new issues is good, but I also didn't see any mention in the changelog, so was unclear what to make of it. This PR title and associated commit messages also don't indicate new errors being caught.

@nirvdrum
Copy link

I didn't follow git blame far enough. The issue was introduced in #4128. This PR moved some of the code from that PR around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobzhang @nirvdrum