This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Update jsx v4 doc #659
Merged
Update jsx v4 doc #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- about not adding `@rescript/react` into v3-deps
cristianoc
reviewed
Sep 27, 2022
cli/JSXV4.md
Outdated
| @@ -29,6 +29,8 @@ To build certain dependencies in V3 compatibility mode, whatever the version use | |||
|
|
|||
| In V3 compatibility mode, the listed dependencies are built in V3 mode, and in addition `-open ReatcV3` is added to the compiler options, so that the `ReactV3` compatibility module in rescript-react is used. | |||
|
|
|||
| > Note that `@rescript/react` is not necessary adding in the `v3-dependencies`, or it would make the cyclic dependencies error. | |||
There was a problem hiding this comment.
Note: do not add @rescript/reactin the v3-dependencies, or it will cause a cyclic dependencies error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about not adding
@rescript/reactinto v3-deps