Add grape/swagger defaultValue support #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RuboCop! please fix the build to start. |
|
This needs a CHANGELOG entry and a README update, please. |
|
rubochangeme updated. |
|
Would you please squash these? I'll do a thorough review soon. |
|
|
||
| params do | ||
| requires :id, type: Integer, desc: 'Coffee ID' | ||
| requires :temperature, type: Integer, desc: 'Temperature of the coffee in celcius', documentation: {example: 72} |
|
Would you mind squashing these and rebasing? There were a bunch of changes upstream. Add a comment so I can merge this after, please. Sorry for the hassle. |
thatsanicehat
force-pushed
the
master
branch
2 times, most recently
from
476a880 to
a0ab498
Compare
|
Squashed/rebased. no problem at all. |
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| #### Features | |||
|
|
|||
| * [#215](https://github.com/tim-vandecasteele/grape-swagger/pull/217): Support swagger `defaultValue` without the need to set a Grape `default` - [@jv-dan](https://github.com/jv-dan). | |||
There was a problem hiding this comment.
This was already released, move this up to Next please.
thatsanicehat
force-pushed
the
master
branch
2 times, most recently
from
5284406 to
cd6f838
Compare
| @@ -1,6 +1,6 @@ | |||
| ### 0.10.2 (Next) | |||
|
|
|||
| * Your contribution here. | |||
There was a problem hiding this comment.
Put back that one, below! Thanks. I promise, last request.
…ithout a Grape default
|
Should be all set once Travis does his thing |
dblock
added a commit
that referenced
this pull request
Mar 12, 2015
Add grape/swagger defaultValue support
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #215