Skip to content

Drop old appraisals #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Drop old appraisals #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
144708e
Drop old appraisals
NikolayRys Oct 13, 2019
f5279ab
Add changelog entry for dropping old appraisals
NikolayRys Oct 13, 2019
24925a2
Remove test workaround for Rails 3
NikolayRys Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
appraise 'rails-3' do
gem 'rails', '3.2.22.5'
gem 'rack-cache', '<= 1.2' # Pin as next rack-cache version (1.3) removes Ruby1.9 support
end

appraise 'rails-4' do
gem 'rails', '4.2.10'
end

appraise 'rails-5' do
gem 'rails', '5.2.1'
end
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#### Fixes

* Your contribution here.
* [#1916](https://github.com/ruby-grape/grape/pull/1916): Drop old appraisals - [@NikolayRys](https://github.com/NikolayRys).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: be explicit? How about "drop Rails 3 and 4 support"? If we're no longer testing, we aren't supporting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, probs, I reword it, but initially my assumption was that you don't support for a long time(since you have removed them from the travis build), so what I did was just a clean-up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. I'm good with this.

* [#1911](https://github.com/ruby-grape/grape/pull/1911): Make sure `Grape::Valiations::AtLeastOneOfValidator` properly treats nested params in errors - [@dnesteryuk](https://github.com/dnesteryuk).
* [#1893](https://github.com/ruby-grape/grape/pull/1893): Allows `Grape::API` to behave like a Rack::app in some instances where it was misbehaving - [@myxoh](https://github.com/myxoh).
* [#1898](https://github.com/ruby-grape/grape/pull/1898): Refactor `ValidatorFactory` to improve memory allocation - [@Bhacaz](https://github.com/Bhacaz).
Expand Down
36 changes: 0 additions & 36 deletions gemfiles/rails_3.gemfile
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions gemfiles/rails_4.gemfile
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions spec/grape/integration/rack_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@
}
env = Rack::MockRequest.env_for('/', options)

unless RUBY_PLATFORM == 'java'
major, minor, patch = Rack.release.split('.').map(&:to_i)
patch ||= 0 # rack <= 1.5.2 does not specify patch version
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6)))
end

expect(JSON.parse(app.call(env)[2].body.first)['params_keys']).to match_array('test')
ensure
input.close
Expand Down