Skip to content

Make Clippy happy. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Oct 9, 2019

No description provided.

@m-ou-se m-ou-se requested a review from a team as a code owner October 9, 2019 11:05
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ithinuel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Oct 9, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 28, 2019
172: Make Clippy happy. r=therealprof a=m-ou-se



Co-authored-by: Mara Bos <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 28, 2019

Build succeeded

@bors bors bot merged commit a3289cb into rust-embedded:master Oct 28, 2019
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
172: doc: Remove obsolete references to `entry!` r=korken89 a=chrysn

In some parts of the documentation `entry!` survived the change to `#[entry]` in f2a155a.

I've removed expanded example of `entry!(main)` as there is more going on now.

The link now points across crates using an explicit hyperlink, I didn't get anything better (ie. something where `cargo doc` would know where to point it) to run.

Co-authored-by: chrysn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants