Skip to content

Move docs.rs link code from controller to version model #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 30, 2021

If we want to reuse this in other places then this code should live on the model, not a specific controller.

r? @pichfl

@locks
Copy link
Contributor

locks commented Feb 1, 2021

Looks good!

@locks
Copy link
Contributor

locks commented Feb 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 1, 2021

📌 Commit b881199 has been approved by locks

@bors
Copy link
Contributor

bors commented Feb 1, 2021

⌛ Testing commit b881199 with merge 30ce0b4...

@bors
Copy link
Contributor

bors commented Feb 1, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 30ce0b4 to master...

@bors bors merged commit 30ce0b4 into rust-lang:master Feb 1, 2021
@Turbo87 Turbo87 deleted the docs-link branch February 1, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants