Skip to content

Show "Try on Rust Playground" button for crates that are available there #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2021
Merged

Show "Try on Rust Playground" button for crates that are available there #3211

merged 5 commits into from
Mar 1, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 28, 2021 •
edited
Loading

Bildschirmfoto 2021-01-28 um 18 06 47

r? @pichfl

@Turbo87 Turbo87 force-pushed the playground-button branch 2 times, most recently from 7fb805a to 1700f81 Compare January 28, 2021 17:24
@bors
Copy link
Contributor

bors commented Feb 1, 2021

☔ The latest upstream changes (presumably #3216) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Feb 1, 2021

☔ The latest upstream changes (presumably #3215) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the playground-button branch 3 times, most recently from b0de949 to 9889c60 Compare February 2, 2021 11:50
@carols10cents
Copy link
Member

@shepmaster We'd love your feedback on this feature and the best way to implement it to make it easy for people to try available crates out on the playground but not add playground support burden (likely in the form of "can I have x crate on the playground too?")

We're currently thinking it would make more sense to show this button only for those crates that are available on the playground by virtue of being in the top 100 crates, not because they're a dependency of the top 100 (I will open an issue on the playground repo to discuss the possibility of having that available from the playground as an API).

We'd show the button that says "Try this crate on the playground" along with some text that says "The top 100 crates are available in the online Rust playground" or similar. What do you think?

@carols10cents carols10cents mentioned this pull request Feb 5, 2021
Open
@carols10cents
Copy link
Member

Playground issue opened: rust-lang/rust-playground#676

@Turbo87 Turbo87 added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Feb 11, 2021
@bors
Copy link
Contributor

bors commented Feb 12, 2021

☔ The latest upstream changes (presumably #3277) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 marked this pull request as ready for review February 13, 2021 09:23
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 13, 2021

We'd show the button that says "Try this crate on the playground" along with some text that says "The top 100 crates are available in the online Rust playground" or similar.

I've added the help text and a bunch of tests for the functionality. This should be ready to go now :)

@bors
Copy link
Contributor

bors commented Feb 22, 2021

☔ The latest upstream changes (presumably #3261) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the playground-button branch 2 times, most recently from f569d44 to 5bb6791 Compare February 25, 2021 10:59
@bors
Copy link
Contributor

bors commented Feb 25, 2021

☔ The latest upstream changes (presumably #3330) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the playground-button branch 3 times, most recently from 8b2fd95 to 7a92da9 Compare February 27, 2021 13:20
@Turbo87 Turbo87 force-pushed the playground-button branch from 7a92da9 to 454ed8e Compare March 1, 2021 19:32
@pichfl
Copy link

pichfl commented Mar 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 454ed8e has been approved by pichfl

bors added a commit that referenced this pull request Mar 1, 2021
@bors
Auto merge of #3211 - Turbo87:playground-button, r=pichfl
90a28a2 
Show "Try on Rust Playground" button for crates that are available there

<img width="989" alt="Bildschirmfoto 2021-01-28 um 18 06 47" src="https://user-images.githubusercontent.com/141300/106173514-4d029100-6194-11eb-8c15-0e05aba9c81f.png">

r? `@pichfl`
@bors
Copy link
Contributor

bors commented Mar 1, 2021

⌛ Testing commit 454ed8e with merge 90a28a2...

@bors
Copy link
Contributor

bors commented Mar 1, 2021

💔 Test failed - checks-actions

@Turbo87 Turbo87 force-pushed the playground-button branch from 454ed8e to 76bbf59 Compare March 1, 2021 21:15
@Turbo87
Copy link
Member Author

Turbo87 commented Mar 1, 2021

fixed the broken test that was caused by 303e515 😅

@bors r=pichfl

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 76bbf59 has been approved by pichfl

@bors
Copy link
Contributor

bors commented Mar 1, 2021

⌛ Testing commit 76bbf59 with merge bf3b2e8...

@bors
Copy link
Contributor

bors commented Mar 1, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing bf3b2e8 to master...

@bors bors merged commit bf3b2e8 into rust-lang:master Mar 1, 2021
@Turbo87 Turbo87 deleted the playground-button branch March 1, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@locks locks

@pichfl pichfl

Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Turbo87 @bors @carols10cents @pichfl @locks @rust-highfive