Skip to content

Implement and use /crates/:crate_id/range/:range route #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 9, 2021

... that redirects the user to the highest version that satisfies the specified semver range. I guess the added test cases should explain the purpose quite well :)

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 10, 2021

btw I'm still wondering if range is the right route name. the semver npm dependency calls it "ranges", but the semver crates calls it a VersionReq. we could also consider naming the route semver instead or something like that. feel free to suggest better alternatives :)

@Turbo87 Turbo87 added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Feb 11, 2021
@Turbo87 Turbo87 force-pushed the range branch 5 times, most recently from 3291530 to 03fc34a Compare February 27, 2021 13:20
Turbo87 added 2 commits March 1, 2021 20:29
... that redirects the user to the highest version that satisfies the specified semver range
@bors
Copy link
Contributor

bors commented Mar 1, 2021

☔ The latest upstream changes (presumably #3346) made this pull request unmergeable. Please resolve the merge conflicts.

@pichfl
Copy link

pichfl commented Mar 1, 2021

I think range should be acceptable for now.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 9bfefad has been approved by pichfl

@bors
Copy link
Contributor

bors commented Mar 1, 2021

⌛ Testing commit 9bfefad with merge c43c92f...

@bors
Copy link
Contributor

bors commented Mar 1, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing c43c92f to master...

@bors bors merged commit c43c92f into rust-lang:master Mar 1, 2021
@Turbo87 Turbo87 deleted the range branch March 1, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants