Skip to content

Implement and use /crates/:crate_id/range/:range route #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/dependency-list/row.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

<span>
<LinkTo
@route="crate"
@model={{@dependency.crate_id}}
@route="crate.range"
@models={{array @dependency.crate_id @dependency.req}}
local-class="link"
{{on "focusin" (fn this.setFocused true)}}
{{on "focusout" (fn this.setFocused false)}}
Expand Down
1 change: 1 addition & 0 deletions app/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Router.map(function () {
this.route('dependencies');
this.route('version', { path: '/:version_num' });
this.route('version-dependencies', { path: '/:version_num/dependencies' });
this.route('range', { path: '/range/:range' });

this.route('reverse-dependencies', { path: 'reverse_dependencies' });

Expand Down
26 changes: 26 additions & 0 deletions app/routes/crate/range.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';

import maxSatisfying from 'semver/ranges/max-satisfying';

export default class VersionRoute extends Route {
@service notifications;
@service router;

async model({ range }) {
let crate = this.modelFor('crate');

let versions = await crate.get('versions');
let allVersionNums = versions.map(it => it.num);
let unyankedVersionNums = versions.filter(it => !it.yanked).map(it => it.num);

// find a version that matches the specified range
let versionNum = maxSatisfying(unyankedVersionNums, range) ?? maxSatisfying(allVersionNums, range);
if (!versionNum) {
this.notifications.error(`No matching version of crate '${crate.name}' found for: ${range}`);
this.replaceWith('crate.index');
}

this.router.replaceWith('crate.version', versionNum);
}
}
78 changes: 78 additions & 0 deletions tests/routes/crate/range-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
import { currentURL, visit } from '@ember/test-helpers';
import { module, test } from 'qunit';

import { setupApplicationTest } from 'cargo/tests/helpers';

module('Route | crate.range', function (hooks) {
setupApplicationTest(hooks);

test('happy path', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0' });
this.server.create('version', { crate, num: '1.1.0' });
this.server.create('version', { crate, num: '1.2.0' });
this.server.create('version', { crate, num: '1.2.3' });

await visit('/crates/foo/range/^1.1.0');
assert.equal(currentURL(), `/crates/foo/1.2.3`);
assert.dom('[data-test-crate-name]').hasText('foo');
assert.dom('[data-test-crate-version]').hasText('1.2.3');
assert.dom('[data-test-notification-message]').doesNotExist();
});

test('happy path with tilde range', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0' });
this.server.create('version', { crate, num: '1.1.0' });
this.server.create('version', { crate, num: '1.1.1' });
this.server.create('version', { crate, num: '1.2.0' });

await visit('/crates/foo/range/~1.1.0');
assert.equal(currentURL(), `/crates/foo/1.1.1`);
assert.dom('[data-test-crate-name]').hasText('foo');
assert.dom('[data-test-crate-version]').hasText('1.1.1');
assert.dom('[data-test-notification-message]').doesNotExist();
});

test('ignores yanked versions if possible', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0' });
this.server.create('version', { crate, num: '1.1.0' });
this.server.create('version', { crate, num: '1.1.1' });
this.server.create('version', { crate, num: '1.2.0', yanked: true });

await visit('/crates/foo/range/^1.0.0');
assert.equal(currentURL(), `/crates/foo/1.1.1`);
assert.dom('[data-test-crate-name]').hasText('foo');
assert.dom('[data-test-crate-version]').hasText('1.1.1');
assert.dom('[data-test-notification-message]').doesNotExist();
});

test('falls back to yanked version if necessary', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0', yanked: true });
this.server.create('version', { crate, num: '1.1.0', yanked: true });
this.server.create('version', { crate, num: '1.1.1', yanked: true });
this.server.create('version', { crate, num: '2.0.0' });

await visit('/crates/foo/range/^1.0.0');
assert.equal(currentURL(), `/crates/foo/1.1.1`);
assert.dom('[data-test-crate-name]').hasText('foo');
assert.dom('[data-test-crate-version]').hasText('1.1.1');
assert.dom('[data-test-notification-message]').doesNotExist();
});

test('redirects to main crate page if no match found', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0' });
this.server.create('version', { crate, num: '1.1.0' });
this.server.create('version', { crate, num: '1.1.1' });
this.server.create('version', { crate, num: '2.0.0' });

await visit('/crates/foo/range/^3');
assert.equal(currentURL(), `/crates/foo`);
assert.dom('[data-test-crate-name]').hasText('foo');
assert.dom('[data-test-crate-version]').hasText('2.0.0');
assert.dom('[data-test-notification-message="error"]').hasText("No matching version of crate 'foo' found for: ^3");
});
});