routes/application: Add routeName tag to all issues
#3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
locks
reviewed
Feb 12, 2021
| @service session; | ||
|
|
||
| beforeModel() { | ||
| this.router.on('routeDidChange', () => { |
There was a problem hiding this comment.
Don't you want to put this in the router itself?
There was a problem hiding this comment.
hmm, I thought extending the router was discouraged these days 🤔
There was a problem hiding this comment.
Hhmm, yeah let's leave it like this.
|
@bors r+ |
|
📌 Commit 3e93bb4 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully make it easier to identify which routes have the most issues 😅